Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CREATE OR REPLACE FLOW #5001

Merged
merged 7 commits into from
Nov 19, 2024
Merged

feat: CREATE OR REPLACE FLOW #5001

merged 7 commits into from
Nov 19, 2024

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Nov 15, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

impl replace flow

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • impl replace flow on flownode by drop and create on flownode
  • impl replace on metasrv by add a new update_txn for flowname&flow info value
  • change show create flow's output to contain IF NOT EXISTS only to prevent accidently clear internal state if need to run

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 15, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@discord9 discord9 requested a review from WenyXu November 15, 2024 08:10
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Nov 15, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.65992% with 140 lines in your changes missing coverage. Please review.

Project coverage is 83.76%. Comparing base (cdba7b4) to head (5a73a95).
Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5001      +/-   ##
==========================================
- Coverage   84.00%   83.76%   -0.25%     
==========================================
  Files        1146     1149       +3     
  Lines      214002   214765     +763     
==========================================
+ Hits       179775   179899     +124     
- Misses      34227    34866     +639
---- 🚨 Try these New Features:

WenyXu
WenyXu reviewed Nov 15, 2024
View reviewed changes
src/common/meta/src/ddl/create_flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/flow/flow_name.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/flow/flow_info.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/flow.rs Show resolved Hide resolved
WenyXu
WenyXu reviewed Nov 18, 2024
View reviewed changes
src/common/meta/src/ddl/create_flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/create_flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/flow/flow_info.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/flow/flow_info.rs Show resolved Hide resolved
src/common/meta/src/key/flow/flow_name.rs Show resolved Hide resolved
WenyXu
WenyXu approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/common/meta/src/key/flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/flow/flow_info.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu requested a review from fengjiachun November 18, 2024 08:46
killme2008
killme2008 reviewed Nov 19, 2024
View reviewed changes
src/common/meta/src/key/flow/flow_info.rs Outdated Show resolved Hide resolved
src/flow/src/adapter.rs Show resolved Hide resolved
src/flow/src/adapter.rs Show resolved Hide resolved
src/flow/src/server.rs Show resolved Hide resolved
killme2008
killme2008 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 enabled auto-merge November 19, 2024 08:32
@github-actions github-actions bot added docs-required This change requires docs update. and removed docs-not-required This change does not impact docs. labels Nov 19, 2024
@sunng87 sunng87 mentioned this pull request Nov 19, 2024
Closed
@killme2008 killme2008 added this pull request to the merge queue Nov 19, 2024
Merged via the queue into GreptimeTeam:main with commit 4d8fe29 Nov 19, 2024
34 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenyXu WenyXu WenyXu approved these changes

@killme2008 killme2008 killme2008 approved these changes

@zhongzc zhongzc Awaiting requested review from zhongzc zhongzc is a code owner

@fengjiachun fengjiachun Awaiting requested review from fengjiachun

Assignees
No one assigned
Labels
docs-required This change requires docs update.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@discord9 @killme2008 @WenyXu